Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatible with recipe_scrapers v15 #3109

Merged
merged 3 commits into from
Apr 14, 2024

Conversation

smilerz
Copy link
Collaborator

@smilerz smilerz commented Apr 12, 2024

No description provided.

smilerz added 3 commits April 12, 2024 08:11
scrape_me has been deprecated
remove reliance on custom text_scraper class
changed url on test case to generic wildmode vs specific site
@vabene1111
Copy link
Collaborator

thnaks for the update. What do you think about using an rc version of recipe scrapers? It looks pretty stable and I dont wan't to leave this PR here laying around until it becomes hard to merge on the other hand scrapers is a very important part of tandoor 🤔

@smilerz
Copy link
Collaborator Author

smilerz commented Apr 13, 2024

It passes all of our tests. I think it's probably fine.

@vabene1111 vabene1111 merged commit 91d3c43 into TandoorRecipes:develop Apr 14, 2024
4 checks passed
@smilerz smilerz deleted the recipe_scrapers branch July 8, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants